chore: Project Cleanup, Group to Folder Conversion, and SwiftLint Upgrade#2003
Merged
austincondiff merged 21 commits intoCodeEditApp:mainfrom Mar 5, 2025
Merged
Conversation
austincondiff
changed the title
austincondiff
requested review from
0xWDG,
FastestMolasses,
matthijseikelenboom,
thecoolwinter and
tom-ludwig
FastestMolasses
previously approved these changes
Mar 4, 2025
thecoolwinter
requested changes
Mar 5, 2025
Collaborator
thecoolwinter
left a comment
thecoolwinter
left a comment
There was a problem hiding this comment.
Lots of little changes, want to make sure we aren't breaking anything so I've got a few clarifying questions.
CodeEdit/Features/Documents/WorkspaceDocument/WorkspaceDocument+Find.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Documents/WorkspaceDocument/WorkspaceDocument+Find.swift
Show resolved
Hide resolved
Collaborator
Author
|
There is one last warning in ExtensionSceneView that I can't seem to figure out a solution to... 
|
6 tasks
thecoolwinter
requested changes
Mar 5, 2025
Collaborator
thecoolwinter
left a comment
thecoolwinter
left a comment
There was a problem hiding this comment.
Two quick remaining things related to reverting that URL+Identifiable change
CodeEdit/Features/OpenQuickly/ViewModels/OpenQuicklyViewModel.swift
Outdated
Show resolved
Hide resolved
austincondiff
changed the title
Collaborator
|
Good stuff, glad to have the CI runner updated and using folders will be so nice for dealing with conflicts. |
FastestMolasses
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This is an emergency fix and is necessary for our test runner to work properly moving forward. That said, as always, please review carefully.
Description
Prepared project to use folders instead of groups by matching groups with filesystem.
Upgraded to SwiftLint 58 and fixed SwiftLint issues caused by the upgrade.
Converted Xcode groups to folders
Checklist